Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-673: Interactive Modal Redesign #1456

Merged
merged 16 commits into from
Oct 4, 2024

Conversation

rstijerina
Copy link
Member

@rstijerina rstijerina commented Oct 3, 2024

Overview:

Redesigns the Interactive Modal based on feedback. Refactored to use shared context.

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Select an interactive app, like https://designsafe.dev/workspace/opensees-interactive?appVersion=3.7.0
  2. Confirm submit button text is changed to "Launch Session"
  3. Submit job, and confirm UI looks like photo 2 below
  4. When session is ready, confirm UI looks like photo 3 below

UI Photos:

  1. New submit button for interactive apps
    Screenshot 2024-10-03 at 6 50 50 PM

  2. Upon interactive app launch
    Screenshot 2024-10-03 at 6 50 08 PM

  3. When session is ready and modal is still open, or if user clicks "Open" button when session is ready
    Screenshot 2024-10-03 at 6 48 09 PM

Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and Tested. LGTM.

@rstijerina rstijerina merged commit e409cbe into main Oct 4, 2024
5 checks passed
@rstijerina rstijerina deleted the task/WP-673--WA-374--apps-forms-improvments branch October 4, 2024 17:02
@wesleyboar
Copy link
Collaborator

✅ Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants